Repository navigation
Install the package from the build context in the Docker image - #99
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Co-authored-by: multica-agent <github@multica.ai>
|
After merge, the published
Either works for me. Since 0.10.0 is not on PyPI yet, option 1 seems simplest. A PyPI upload of the same release would also help, because Home Assistant installs pynx584 from PyPI. |
|
Makes sense to me to install from the tag and not pypi because the pypi release doesn't have the actual docker build stuff in it anyway. The point is that there's a race between pushing to pypi, it being available as the top version and pushing the tag to git right? Either way, building from the tag commit is the safest thing to make sure image X has code X in it, IMHO. That said, I don't understand option 1.. the tag is on the top-most commit AFAICT, no merge commit that is higher or anything. Am I good to just merge this? |
|
Yes, please merge. Sorry, option 1 was not clear. Simpler: after the merge, bump If you can also upload 0.10.1 to PyPI, that would help: Home Assistant installs pynx584 from PyPI. |
|
Ah right, okay. For some reason last night I was reading 1 and 2 as alternatives to merging this. |
Install pynx584 from the build context in the Docker image
The Dockerfile installed
pynx584from PyPI, so the image never contained the code of the commit it was built from. PyPI has 0.9.0 only, so the image published as0.10.0runs 0.9.0 (/versionanswers 1.2 and/systemanswers 404).This change copies
setup.py,nx584_server,nx584_clientandnx584/into the image and runspip install /src.Tested with a local build from 0.10.0:
pip show pynx584reports 0.10.0,/versionanswers 1.3 and/systemanswers 200.Note:
latestis built frommaster, so after this change it carries the currentmastercode instead of the last PyPI release. Please confirm that this is acceptable.